Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): generate an sdk with spec from npm #1678

Merged
merged 1 commit into from May 14, 2024

Conversation

fpaul-1A
Copy link
Contributor

Proposed change

The goal is to be able to generate an SDK with the necessary setup to fetch the spec file form an npm registry

Related issues

  • 🐛 Fixes #(issue)
  • 🚀 Feature #(issue)

@fpaul-1A fpaul-1A force-pushed the feat/sdk-with-npm-spec branch 2 times, most recently from 69c98fe to 59af1c7 Compare April 18, 2024 15:14
@fpaul-1A fpaul-1A force-pushed the feat/sdk-with-npm-spec branch 3 times, most recently from 316cd7e to cb381d7 Compare April 22, 2024 09:20
@fpaul-1A fpaul-1A changed the title [draft] feat(sdk): generate an sdk with spec from npm feat(sdk): generate an sdk with spec from npm Apr 22, 2024
@fpaul-1A fpaul-1A marked this pull request as ready for review April 22, 2024 09:20
@fpaul-1A fpaul-1A requested a review from a team as a code owner April 22, 2024 09:20
@fpaul-1A fpaul-1A force-pushed the feat/sdk-with-npm-spec branch 3 times, most recently from 9284ce1 to 44f41b4 Compare April 22, 2024 10:07
@fpaul-1A fpaul-1A force-pushed the feat/sdk-with-npm-spec branch 2 times, most recently from 2b631c6 to 3e26d3a Compare April 22, 2024 14:43
@fpaul-1A fpaul-1A force-pushed the feat/sdk-with-npm-spec branch 3 times, most recently from b7b24c4 to 43f645a Compare April 23, 2024 12:32
mrednic-1A
mrednic-1A previously approved these changes Apr 25, 2024
kpanot
kpanot previously approved these changes Apr 25, 2024
packages/@ama-sdk/core/cli/update-spec-from-npm.cts Outdated Show resolved Hide resolved
@fpaul-1A fpaul-1A force-pushed the feat/sdk-with-npm-spec branch 4 times, most recently from a326a1d to a57078c Compare April 30, 2024 15:47
mrednic-1A
mrednic-1A previously approved these changes May 2, 2024
name: NodePackageName,
options: {
command: 'exec',
packageName: `exec ${this.script} ${packageManager === 'npm' ? '-- ' : ''}${this.args.join(' ')}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
packageName: `exec ${this.script} ${packageManager === 'npm' ? '-- ' : ''}${this.args.join(' ')}`,
packageName: `exec ${this.script} ${packageManager === 'npm' ? '-- ' : ''}${this.args.map((arg) => `"${arg}"`).join(' ')}`,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@mrednic-1A mrednic-1A added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 89fcb9b May 14, 2024
28 checks passed
@mrednic-1A mrednic-1A deleted the feat/sdk-with-npm-spec branch May 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants