New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): generate an sdk with spec from npm #1678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
project:@ama-sdk/core
project:@ama-sdk/schematics
project:@ama-sdk/create
labels
Apr 17, 2024
kpanot
reviewed
Apr 17, 2024
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
from
April 18, 2024 08:59
403946c
to
254e4bf
Compare
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
2 times, most recently
from
April 18, 2024 15:14
69c98fe
to
59af1c7
Compare
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
3 times, most recently
from
April 22, 2024 09:20
316cd7e
to
cb381d7
Compare
fpaul-1A
changed the title
[draft] feat(sdk): generate an sdk with spec from npm
feat(sdk): generate an sdk with spec from npm
Apr 22, 2024
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
3 times, most recently
from
April 22, 2024 10:07
9284ce1
to
44f41b4
Compare
kpanot
reviewed
Apr 22, 2024
packages/@ama-sdk/schematics/schematics/typescript/core/index.spec.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Apr 22, 2024
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
2 times, most recently
from
April 22, 2024 14:43
2b631c6
to
3e26d3a
Compare
mrednic-1A
reviewed
Apr 22, 2024
kpanot
reviewed
Apr 23, 2024
packages/@ama-sdk/schematics/schematics/typescript/shell/templates/base/package.json.template
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
3 times, most recently
from
April 23, 2024 12:32
b7b24c4
to
43f645a
Compare
mrednic-1A
previously approved these changes
Apr 25, 2024
kpanot
previously approved these changes
Apr 25, 2024
fpaul-1A
dismissed stale reviews from kpanot, mrednic-1A, and vscaiceanu-1a
via
April 29, 2024 08:00
3de340a
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
from
April 29, 2024 08:00
172fdb0
to
3de340a
Compare
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
4 times, most recently
from
April 29, 2024 16:58
9d3165c
to
f470d7d
Compare
mrednic-1A
reviewed
Apr 30, 2024
fpaul-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
4 times, most recently
from
April 30, 2024 15:47
a326a1d
to
a57078c
Compare
mrednic-1A
previously approved these changes
May 2, 2024
kpanot
reviewed
May 2, 2024
name: NodePackageName, | ||
options: { | ||
command: 'exec', | ||
packageName: `exec ${this.script} ${packageManager === 'npm' ? '-- ' : ''}${this.args.join(' ')}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
packageName: `exec ${this.script} ${packageManager === 'npm' ? '-- ' : ''}${this.args.join(' ')}`, | |
packageName: `exec ${this.script} ${packageManager === 'npm' ? '-- ' : ''}${this.args.map((arg) => `"${arg}"`).join(' ')}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
mrednic-1A
force-pushed
the
feat/sdk-with-npm-spec
branch
from
May 2, 2024 12:38
a57078c
to
196526e
Compare
mrednic-1A
approved these changes
May 2, 2024
16 tasks
kpanot
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The goal is to be able to generate an SDK with the necessary setup to fetch the spec file form an npm registry
Related issues