-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: library integration tests #1725
Open
vscaiceanu-1a
wants to merge
1
commit into
main
Choose a base branch
from
feature/lib-it-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 87bec2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
project:@o3r/analytics
project:@o3r/apis-manager
project:@o3r/core
project:@o3r/components
project:@o3r/configuration
project:@o3r/create
project:@o3r/design
project:@o3r/eslint-config-otter
project:@o3r/extractors
project:@o3r/localization
project:@o3r/rules-engine
project:@o3r/styling
project:@o3r/stylelint-plugin
project:@o3r/testing
project:@o3r/test-helpers
labels
Apr 26, 2024
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
3 times, most recently
from
April 29, 2024 15:33
f248a91
to
53c3a0a
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
4 times, most recently
from
May 2, 2024 14:19
7bea4b5
to
5bcbf47
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
from
May 3, 2024 13:55
5bcbf47
to
ab8a8f6
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
3 times, most recently
from
May 6, 2024 14:39
bfce00d
to
8f216a6
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
3 times, most recently
from
May 6, 2024 15:58
8b80ba0
to
87229ad
Compare
kpanot
reviewed
May 7, 2024
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
7 times, most recently
from
May 13, 2024 12:22
f315253
to
d77732a
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
7 times, most recently
from
May 22, 2024 14:03
c4bde64
to
3efc10c
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
3 times, most recently
from
May 27, 2024 14:28
2c5f972
to
0d5a0c0
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
from
May 28, 2024 08:20
0d5a0c0
to
87bec2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
project:@ama-sdk/create
project:@o3r/analytics
project:@o3r/apis-manager
project:@o3r/application
project:@o3r/components
project:@o3r/configuration
project:@o3r/core
project:@o3r/create
project:@o3r/design
project:@o3r/eslint-config-otter
project:@o3r/extractors
project:@o3r/localization
project:@o3r/rules-engine
project:@o3r/schematics
project:@o3r/stylelint-plugin
project:@o3r/styling
project:@o3r/test-helpers
project:@o3r/testing
project:@o3r/workspace
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Enhance the integration test campaign with tests for libraries.
@o3r/create
should generate a project with a library@o3r/workspace
schematic for app and lib. Currently in create int tests, to be moved in workspace ones. feat(sdk): generate an sdk with spec from npm #1678 should be merged first.Ensure test coverage for libs (similar to what we have for apps) and add assertions for app tests for: