Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: library integration tests #1725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vscaiceanu-1a
Copy link
Member

@vscaiceanu-1a vscaiceanu-1a commented Apr 26, 2024

Proposed change

Enhance the integration test campaign with tests for libraries.

  • @o3r/create should generate a project with a library
  • base Otter project should contain a library as well (along with an application)
  • check generated files by @o3r/workspace schematic for app and lib. Currently in create int tests, to be moved in workspace ones. feat(sdk): generate an sdk with spec from npm #1678 should be merged first.

Ensure test coverage for libs (similar to what we have for apps) and add assertions for app tests for:

Copy link

nx-cloud bot commented Apr 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 87bec2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=test-int --parallel 3
✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/lib-it-tests branch 3 times, most recently from 8b80ba0 to 87229ad Compare May 6, 2024 15:58
@vscaiceanu-1a vscaiceanu-1a marked this pull request as ready for review May 6, 2024 19:11
@vscaiceanu-1a vscaiceanu-1a requested a review from a team as a code owner May 6, 2024 19:11
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/lib-it-tests branch 7 times, most recently from f315253 to d77732a Compare May 13, 2024 12:22
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/lib-it-tests branch 7 times, most recently from c4bde64 to 3efc10c Compare May 22, 2024 14:03
@vscaiceanu-1a vscaiceanu-1a force-pushed the feature/lib-it-tests branch 3 times, most recently from 2c5f972 to 0d5a0c0 Compare May 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment