fix: TypeExpression - do not break type using walkTypes method (P…

…HP-CS-Fixer#7785)
zoonru · Feb 2, 2024 · 6c9263a · 6c9263a
1 parent 860b721
commit 6c9263a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/DocBlock/TypeExpression.php b/src/DocBlock/TypeExpression.php
@@ -241,7 +241,7 @@ public function getTypesGlue(): string
      */
     public function walkTypes(\Closure $callback): void
     {
-        foreach ($this->innerTypeExpressions as [
+        foreach (array_reverse($this->innerTypeExpressions) as [
             'start_index' => $startIndex,
             'expression' => $inner,
         ]) {

diff --git a/tests/DocBlock/TypeExpressionTest.php b/tests/DocBlock/TypeExpressionTest.php
@@ -612,6 +612,24 @@ public static function provideAllowsNullCases(): iterable
         yield ['?\Closure(): void', true];
     }
 
+    public function testWalkTypes(): void
+    {
+        $typeExpression = new TypeExpression('Foo|Bar|Baz', null, []);
+        $addLeadingSlash = static function (TypeExpression $type): void {
+            \Closure::bind(static function () use ($type): void {
+                $value = $type->toString();
+                if (!str_starts_with($value, '\\')) {
+                    $value = '\\'.$value;
+                }
+                $type->value = $value;
+            }, null, TypeExpression::class)();
+        };
+
+        $typeExpression->walkTypes($addLeadingSlash);
+
+        self::assertSame('\Foo|\Bar|\Baz', $typeExpression->toString());
+    }
+
     /**
      * @dataProvider provideSortTypesCases
      */