Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 7 #184

Merged
merged 5 commits into from Jun 7, 2022
Merged

Support Rails 7 #184

merged 5 commits into from Jun 7, 2022

Conversation

vitalinfo
Copy link
Contributor

No description provided.

@schneems
Copy link
Member

schneems commented Jun 6, 2022

Thanks for the PR. This seems like a major oversight. Can you rebase against master/main as I just released 0.6.1 also add a changelog entry for this.

I'm also thinking that we should be more permissive by default, I would like you to change the check to >= 3 instead of explicit rails versions.

@vitalinfo
Copy link
Contributor Author

@schneems done

@schneems schneems merged commit 69d2f31 into zombocom:master Jun 7, 2022
@schneems
Copy link
Member

schneems commented Jun 7, 2022

Thanks! As a side note, it's generally a good idea to leave the version number alone when making a PR as the maintainer might have pulled in other breaking changes or things that require a different version bump.

Usually I do version revisions separately. It's not a blocker, and in this case I think we can release this as 0.6.2 but for future PRs it will be better to not touch the version number.

@schneems
Copy link
Member

schneems commented Jun 7, 2022

0.6.2 is released with this

@vitalinfo
Copy link
Contributor Author

@schneems thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants