Added support for HTTPS and mutual TLS (mTLS) #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/https-support
branch
2 times, most recently
from
216075b
to
3e175c8
Compare
|
@andy-maier In our use case, we wanna configure the mTLS related parameters in zhmc exporter's credential yaml. Could you implement loading the mTLS parameters from credential yaml like below: This way/configuration is our other exporters are using. Thanks. |
|
@Charles1000Chen I agree this is the better solution. DONE. |
andy-maier
force-pushed
the
andy/https-support
branch
7 times, most recently
from
1015aa6
to
ab840e2
Compare
EdGue42
reviewed
Aug 1, 2023
andy-maier
force-pushed
the
andy/https-support
branch
3 times, most recently
from
b8abe46
to
c77f867
Compare
andy-maier
force-pushed
the
andy/https-support
branch
2 times, most recently
from
02f8ee0
to
1f64287
Compare
|
I updated the PR to use the prometheus-client package from its master branch, now that PR prometheus/client_python#946 has been merged. |
Details: * Added support for communicating with Prometheus using HTTPS by adding a new section 'prometheus' to the HMC credentials file, that can specify server certificate and key files, CA credentials file for validating client certificates (mTLS), and a flag for disabling client vertificate validation. * Since it makes sense to also specify the port for exporting in the new 'prometheus' section, that was also added. The -p command line option overrides the port specified in the HMC credentials file, which defaults to 9291, so this is backwards compatible. * For now, the prometheus-client package is installed from its master branch. Once its new version has been released, it will need to be installed again from Pypi (search for TODO-PYPI in whole repo). Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/https-support
branch
from
1f64287
to
4f6d936
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message, or invoke with
--help-creds.This PR currently uses the prometheus-client package from its master branch.