Skip to content

Added logging for when event isn't a PR #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

mattangus
Copy link
Contributor

A PR was open for the branch I was working on, but just for testing I had set the trigger to be a push

on:
  push:
    branches:
      - my_branch_name

This lead to a confusing message saying that the token didn't exist even when it did.

This PR adds a better message when the problem is the event type.

@zgosalvez zgosalvez self-assigned this Nov 18, 2023
@zgosalvez zgosalvez self-requested a review November 18, 2023 23:51
@zgosalvez zgosalvez added documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 18, 2023
@zgosalvez
Copy link
Owner

Thank you for this, @mattangus! Please update from main and run npm ci for me to merge the changes.

mattangus and others added 2 commits November 22, 2023 10:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mattangus
Copy link
Contributor Author

@zgosalvez done!

@zgosalvez zgosalvez merged commit d648b82 into zgosalvez:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants