Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endless loop caused by ErrCompacted #3774

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Conversation

LeeDF
Copy link
Contributor

@LeeDF LeeDF commented Dec 11, 2023

etcd compact key reversion, this code will use old reversion, endless loop
this log is our production environment log, it's not always happen

image

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #3774 (284661a) into master (431f9af) will decrease coverage by 0.03%.
The diff coverage is 63.63%.

Additional details and impacted files
Files Coverage Δ
core/discov/internal/registry.go 78.98% <63.63%> (-1.18%) ⬇️

@kevwan kevwan force-pushed the master branch 2 times, most recently from fd3ff06 to 284661a Compare December 16, 2023 07:41
@kevwan kevwan added this pull request to the merge queue Dec 17, 2023
Merged via the queue into zeromicro:master with commit 48625fa Dec 17, 2023
WqyJh pushed a commit to WqyJh/go-zero that referenced this pull request Dec 21, 2023
Co-authored-by: lidengfu <lidengfu@excean.com>
dongmeng199 pushed a commit to dongmeng199/go-zero that referenced this pull request Dec 24, 2023
Co-authored-by: lidengfu <lidengfu@excean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants