Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config map with json tag #2974

Merged
merged 3 commits into from
Mar 7, 2023
Merged

fix: config map with json tag #2974

merged 3 commits into from
Mar 7, 2023
+133 −23

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Mar 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #2974 (d9afa06) into master (7d5d7d9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d9afa06 differs from pull request most recent head 8ee7db7. Consider uploading reports for the commit 8ee7db7 to get more accurate results

Impacted Files Coverage Δ
core/conf/config.go 98.60% <100.00%> (+0.07%) ⬆️
core/mapping/utils.go 92.61% <100.00%> (ø)
core/stores/sqlx/sqlconn.go 56.37% <0.00%> (-1.48%) ⬇️
core/stores/sqlx/tx.go 23.30% <0.00%> (+3.88%) ⬆️

@kevwan kevwan added this pull request to the merge queue Mar 7, 2023
Merged via the queue into zeromicro:master with commit dd347e9 Mar 7, 2023
@kevwan kevwan deleted the fix/conf-map-missing branch March 7, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkJoyMa MarkJoyMa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevwan @MarkJoyMa @byops