Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msgpack: truncate long string prefix refinements #167

Merged
merged 2 commits into from
Aug 24, 2023
Merged

msgpack: truncate long string prefix refinements #167

merged 2 commits into from
Aug 24, 2023

Commits on Aug 24, 2023

  1. msgpack: truncate long string prefix refinements 

    Prior to this commit, serialising an unknown value with a string prefix refinement with a sufficiently long prefix would result in an error on deserialisation, since cty limits the size of the refinements blob to 1024 bytes.

We choose an arbitrary maximum length of 256 bytes and truncate any
string prefix refinement on serialisation.

This behaviour is an exception to the general case where refined values
will round-trip losslessly.
    @kmoe
    kmoe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    010b01c View commit details
    Browse the repository at this point in the history

  2. ctystrings: clarify comment

    @kmoe
    kmoe committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    55a402b View commit details
    Browse the repository at this point in the history