Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic eslint import #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dominikberse
Copy link

First off, great project, love the autowire feature.

I had some trouble with the static import of typescript-eslint, which in turn imports typescript, but does not explicitly state a dependency (see typescript-eslint/typescript-eslint#828). This leads to crashes in an environment where the typescript package is not explicitly installed (for example in my production environment).

Maybe I just missed something there, otherwise I would propose to import the typescript-eslint package dynamically, so it's only loaded when actually doing the autowiring process. This allows to exclude the typescript package in builds where you do the autowiring at compile time.

zazoomauro pushed a commit that referenced this pull request Jan 25, 2023
@zazoomauro
Copy link
Owner

@dominikberse can you please fix the conflicts?
happy to deploy a new version today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants