Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edits in docs #1509

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Minor edits in docs #1509

merged 1 commit into from
Oct 26, 2023
+9 −7

Conversation

sanketverma1704
Copy link
Member

@sanketverma1704 sanketverma1704 commented Aug 24, 2023 •
edited
Loading

Hi everyone! 👋🏻

I've made minor changes to the documentation. They are as follows:

  • Change Copyright year; 2022 → 2023
  • Currently, the Specifications page lists out the whole index of V2 and V1 spec. It looks messy. I changed it to display the titles which, upon clicking, would open the respective specification documents.
  • Removed Under development from V3 specification.

PR Preview: https://zarr--1509.org.readthedocs.build/en/1509/

Please review. Thanks!

CC: @zarr-developers/python-core-devs

TODO:

  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Sorry, something went wrong.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 24, 2023
joshmoore
joshmoore approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sanketverma1704
Copy link
Member Author

Can we merge this?

CC: @jakirkham

@d-v-b d-v-b merged commit 5eb737b into zarr-developers:main Oct 26, 2023
@sanketverma1704
Copy link
Member Author

Thanks, @d-v-b! 🙏🏻

dstansby pushed a commit to dstansby/zarr-python that referenced this pull request Oct 31, 2023
@sanketverma1704 @dstansby
Minor edits in docs (zarr-developers#1509)
cbd7bef
@sanketverma1704 sanketverma1704 deleted the doc_updates branch December 27, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sanketverma1704 @joshmoore @d-v-b