Skip to content

Enforce ruff/flake8-comprehensions rules (C4) #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 15, 2024

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Sorry, something went wrong.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (8c7c043) to head (424b8f6).
Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          62       62           
  Lines        2721     2721           
=======================================
  Hits         2719     2719           
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/abc.py 100.00% <100.00%> (ø)
numcodecs/categorize.py 100.00% <100.00%> (ø)
numcodecs/delta.py 100.00% <100.00%> (ø)
numcodecs/fixedscaleoffset.py 100.00% <100.00%> (ø)
numcodecs/json.py 96.07% <100.00%> (ø)
numcodecs/msgpacks.py 100.00% <100.00%> (ø)
numcodecs/pickles.py 100.00% <100.00%> (ø)
numcodecs/quantize.py 100.00% <100.00%> (ø)
numcodecs/tests/test_blosc.py 100.00% <100.00%> (ø)
numcodecs/tests/test_lzma.py 100.00% <ø> (ø)
... and 1 more

@DimitriPapadopoulos DimitriPapadopoulos changed the title Unnecessary generator Enforce ruff/flake8-comprehensions rules (C4) Oct 15, 2024
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PTC-W0015 branch 2 times, most recently from 69f9354 to 3668e6c Compare October 23, 2024 20:28
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the PTC-W0015 branch 2 times, most recently from 5218185 to bcb3ab2 Compare November 16, 2024 07:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
C401 Unnecessary generator (rewrite as a `set` comprehension)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
C408 Unnecessary `dict` call (rewrite as a literal)
@dstansby dstansby merged commit 1855f0c into zarr-developers:main Nov 29, 2024
26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PTC-W0015 branch November 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants