Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE-3664 feat(cli): Use uniform field names in check-missing-app-info util #630

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

gregilo
Copy link
Contributor

@gregilo gregilo commented Mar 6, 2023

Since the BE field names that the API is expecting do not match the names of the flags we're using in the CLI, we need to make sure we're using the proper name in the proper context. This commit ensures that we're using proper names in the CLI error message when check-missing-app-info fails.

Since the BE field names that the API is expecting do not match the
names of the flags we're using in the CLI, we need to make sure we're
using the proper name in the proper context. This commit ensures that
we're using proper names in the CLI error message when
check-missing-app-info fails.
@gregilo gregilo requested a review from kola-er March 6, 2023 21:12
@gregilo gregilo requested review from eliangcs and rnegron as code owners March 6, 2023 21:12
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gregilo gregilo merged commit 38a6093 into main Mar 7, 2023
@gregilo gregilo deleted the PDE-3664 branch March 7, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants