Fix callback already called #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you call multiple callbacks from the loader, the error: Error: callback(): The callback was already called. Will appear. Return early for pre-condition callbacks instead so appropriate error appears in console.
It is not processed by the Plugin.
|
|
|
Thanks @jvoccia for the issue and the PR 👍🏻 |
|
The fix is available in the 6.0.1 🎉 |
|
Thanks @yoriiis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Callbacks were being called multiple times causing incorrect messages in WebPack. Also, if an SVG file was invalid the code was marking the SVG file for processing resulting in some pretty ugly errors when calculating etags.
Fixes: #27
Specific Changes proposed
Reordered pre-conditions checks towards the top of loader.ts. Returned when the callback was called, instead of letting it "fall through", updated tests to catch issue, and ran Prettier.
Requirements Checklist