Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ESM #17

Merged
merged 3 commits into from Jul 31, 2023
Merged

Migrate to ESM #17

merged 3 commits into from Jul 31, 2023

Conversation

yoriiis
Copy link
Owner

@yoriiis yoriiis commented Jun 27, 2023 •
edited

Warning Breaking change: svg-chunk-webpack-plugin@5 will be ESM only

Include webpack bump as peer-dependencies (webpack/webpack#15198)

@yoriiis yoriiis self-assigned this Jun 27, 2023
@yoriiis yoriiis added the enhancement New feature or request label Jun 27, 2023
@yoriiis
Copy link
Owner Author

yoriiis commented Jun 27, 2023

@alexander-akait Hope you are well. I would like to have your opinion on this PR please.
Is it "safe"? I did not find an example of plugin/loader available in ESM.

@yoriiis yoriiis merged commit c6918ec into main Jul 31, 2023
11 checks passed
@yoriiis yoriiis deleted the esm branch July 31, 2023 23:03
@alexander-akait
Copy link
Collaborator

@yoriiis Sorry for delay, it is safe, we support ESM format out of box for webpack.config.(js|mjs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees

@yoriiis yoriiis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoriiis @alexander-akait