Fix emscripten #452
Open
Fix emscripten #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @capocasa. What's the status of this? Is it still WIP? |
|
@yglukhov: It works for latest emscripten but breaks compatibility with older emscripten You could (a) accept merge into master, accept dependency change to newer emscripten version, update emscripten version in CI, (b) accept merge into a new_emscripten dev branch, keep old emscripten version in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more to document progress- unsure how to proceed
I started fixing bugs on emscripten when I realized it would probably have worked with an earlier version, but decided to continue anyway
These work with emscripten 2.0.9 and contain backwords incompatible changes. See also yglukhov/jsbind#14