Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to use .NET SDK 8 and C# 12 #2863

Merged
merged 1 commit into from
Jan 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/.global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "6.0.300",
"version": "8.0.100",
"rollForward": "latestMinor"
}
}
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
with:
dotnet-version: |
2.1.x
3.1.x
6.0.x
8.0.x

- name: Get .NET information
run: dotnet --info
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
with:
dotnet-version: |
2.1.x
3.1.x
6.0.x
8.0.x

- name: Get .NET information
run: dotnet --info
Expand Down
7 changes: 4 additions & 3 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ You will need the following software installed:
* .NET Framework targeting packs for 4.5.2, 4.6, 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
* Windows 10 SDK 10.0.19041.0
* F# desktop language support
* [.NET SDK 6.0](https://dotnet.microsoft.com/download/dotnet/6.0)
* [.NET SDK 8.0](https://dotnet.microsoft.com/download/dotnet/8.0)
* [.NET 6.0 Runtime](https://dotnet.microsoft.com/download/dotnet/6.0)
* [.NET Core 2.0 Runtime](https://dotnet.microsoft.com/download/dotnet/2.0)
* PowerShell (or [PowerShell Core](https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-core-on-windows?view=powershell-6))
* PowerShell (or [PowerShell Core](https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-core-on-windows))

Ensure that you have configured PowerShell to be able to run local unsigned scripts (either by running
`Set-ExecutionPolicy -Scope CurrentUser RemoteSigned` from within PowerShell, or by launching PowerShell with the
Expand All @@ -26,7 +27,7 @@ Ensure that you have configured PowerShell to be able to run local unsigned scri

1. Open PowerShell (or PowerShell Core). (To ensure MSBUILD is on the path, you may wish to start with "Developer Powershell for VS" shortcut.)

1. From the root folder of the source repo, this command will build the code & run all tests:
1. From the root folder of the source repo, this command will build the code and run all tests:

`./build`

Expand Down
4 changes: 2 additions & 2 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ if ($null -eq $targetFunction) {
}

_build_step "Performing pre-build verifications"
_require dotnet "Could not find 'dotnet'. Please ensure .NET SDK 6.0 or later is installed."
_verify_dotnetsdk_version "6.0"
_require dotnet "Could not find 'dotnet'. Please ensure .NET SDK 8.0 or later is installed."
_verify_dotnetsdk_version "8.0"
_require msbuild.exe "Could not find 'msbuild'. Please ensure MSBUILD.EXE v17.0 is on the path."
_verify_msbuild_version "17.0.0"

Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
<LangVersion>10.0</LangVersion>
<LangVersion>12.0</LangVersion>
<MSBuildCopyContentTransitively>false</MSBuildCopyContentTransitively>
<NoWarn>$(NoWarn);NU1603;NU1903;NU5128;NU5131;CS0436;CS1701</NoWarn>
<PackageId>$(MSBuildProjectName)</PackageId>
Expand Down
2 changes: 1 addition & 1 deletion test/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<DebugSymbols>true</DebugSymbols>
<DebugType>portable</DebugType>
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
<LangVersion>10.0</LangVersion>
<LangVersion>12.0</LangVersion>
<MSBuildCopyContentTransitively>false</MSBuildCopyContentTransitively>
<NoWarn>$(NoWarn);NU1603;NU1903;CS1701;MSB3277</NoWarn>
<PackageId>$(MSBuildProjectName)</PackageId>
Expand Down