#2767: Prevent stack overflow in Assert.Equivalent with a max travers…

…al depth of 50 (v3)
xunit · Aug 31, 2023 · ffeeed6 · ffeeed6
1 parent 966a5b7
commit ffeeed6
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/xunit.v3.assert.tests/Asserts/EquivalenceAssertsTests.cs b/src/xunit.v3.assert.tests/Asserts/EquivalenceAssertsTests.cs
@@ -1497,6 +1497,29 @@ public void Actual_Shallow()
 		}
 	}
 
+	public class DepthLimit
+	{
+		[Fact]
+		public void PreventArbitrarilyLargeDepthObjectTree()
+		{
+			var expected = new InfiniteRecursionClass();
+			var actual = new InfiniteRecursionClass();
+
+			var ex = Record.Exception(() => Assert.Equivalent(expected, actual));
+
+			Assert.IsType<EquivalentException>(ex);
+			Assert.Equal(
+				"Assert.Equivalent() Failure: Exceeded the maximum depth 50 with 'Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent.Parent'; check for infinite recursion or circular references",
+				ex.Message
+			);
+		}
+
+		class InfiniteRecursionClass
+		{
+			public InfiniteRecursionClass Parent => new();
+		}
+	}
+
 	public class Indexers
 	{
 		[Fact]

diff --git a/src/xunit.v3.assert/Asserts b/src/xunit.v3.assert/Asserts