Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable permissive max-len and max-lines as warning #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fregante
Copy link
Member

@fregante fregante commented Nov 17, 2023

I think it might make sense to enable them as warning to look at the pushback without creating too much trouble.

I think 200ch is a good upper limit, but I'm not sure about "1000 lines", especially in files with inline documentation and licensing.

@sindresorhus
Copy link
Member

I think 2000 lines is too little.

@fregante
Copy link
Member Author

fregante commented Jun 8, 2024

The point of this warning is to push people to split up larger files. Even you reach the limit, you can just disable it in the file, hopefully as an exception rather than a common occurrence.

2000-lines is already excessive to me, but it could be a start to verify any pushback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reintroduce "length" rules to catch excess
2 participants