-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix COMPILE_MATCHER
#230
base: master
Are you sure you want to change the base?
Fix COMPILE_MATCHER
#230
Conversation
`COMPILE_MATCHER = /^Compile[\w]+\s.+?\s((?:(?:\\.|[^ ])+\/)*((?:\\.|[^ ])+\.(?:m|mm|c|cc|cpp|cxx|swift)))\s.*/` can not match Compile text like `CompileC /Users/finn/Library/Developer/Xcode/DerivedData/QQMSFContact-ezpxxtrwrpdftwfmhlpshulhdsij/Build/Intermediates/Project.build/Debug-iphonesimulator/Project.build/Objects-normal/i386/ObjcFile.o ObjcFile.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler`
Hello! Could this be merged? I found this issue through Infer which relies on I would also suggest adding a test for this. |
@UkuLoskit can't be merged without adding a test to prove the failure |
COMPILE_COMMAND_MATCHER should match source file in the root path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
.rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
.rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout
Error: TheStyle/TrailingComma
cop no longer exists. Please useStyle/TrailingCommaInLiteral
and/orStyle/TrailingCommaInArguments
instead.
(obsolete configuration found in .rubocop.yml, please update it)
remove white spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
.rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
.rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout
Error: TheStyle/TrailingComma
cop no longer exists. Please useStyle/TrailingCommaInLiteral
and/orStyle/TrailingCommaInArguments
instead.
(obsolete configuration found in .rubocop.yml, please update it)
modify test constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Lint/Eval has the wrong namespace - should be Security
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout
.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout
.rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout
.rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
.rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout
.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout
.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout
Error: TheStyle/TrailingComma
cop no longer exists. Please useStyle/TrailingCommaInLiteral
and/orStyle/TrailingCommaInArguments
instead.
(obsolete configuration found in .rubocop.yml, please update it)
@supermarin I added a test, but it failed to pass the CI perfomance check. How can I figure out where the time consumed mostly? Scenario: Performance # features/xcpretty.feature:11
When I run xcpretty over a big file # features/steps/xcpretty_steps.rb:9
Then the performance should be way faster than running cat # features/steps/xcpretty_steps.rb:27
XCPretty run time: 3.360620771
expected: < 2
got: 3.360620771 (RSpec::Expectations::ExpectationNotMetError)
./features/steps/xcpretty_steps.rb:29:in `/^the performance should be way faster than running cat$/'
features/xcpretty.feature:13:in `Then the performance should be way faster than running cat'
Failing Scenarios:
cucumber features/xcpretty.feature:11 # Scenario: Performance |
I compared the performance before and after. The result as follows:
The test environment is:
The test code is:def test
s = Time.now
out = `cat features/fixtures/xcodebuild.log | xcpretty -c`
t = Time.now - s
t
end
10.times.each {|i| puts "#{i+1} : #{test}"} |
The COMPILE_MATCHER
/^Compile[\w]+\s.+?\s((?:\\.|[^ ])+\/((?:\\.|[^ ])+\.(?:m|mm|c|cc|cpp|cxx|swift)))\s.*/
CompileC /Users/finn/Library/Developer/Xcode/DerivedData/Project-ezpxxtrwrpdftwfmhlpshulhdsij/Build/Intermediates/Project.build/Debug-iphonesimulator/Project.build/Objects-normal/i386/ObjcFile.o ObjcFile.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler
CompileC /Users/finn/Library/Developer/Xcode/DerivedData/Project-ezpxxtrwrpdftwfmhlpshulhdsij/Build/Intermediates/Project.build/Debug-iphonesimulator/Project.build/Objects-normal/i386/ObjcFile.o path/ObjcFile.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler