Fix MediaPicker capture methods in Android 13+ #2073
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| // While MD5 is deemed to be not secure anymore, it is not used in a security context here. | ||
| // Here we hash a key value to ensure compatibility with the underlying platform's preferences storage (so the key was a determinate length and didn't exceed platform limits). | ||
| // As part as Microsofts ongoing efforts to secure the .NET ecosystem, this usage of an insecure hashing mechanism was flagged. | ||
| // An exception has been requested for the usage of this "unsafe" hashing mechanism. | ||
| // More details here (internal link): https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1676270 | ||
| // While MD5 is deemed to be not secure anymore, it is not used in a security context here. | ||
| // Here we hash a key value to ensure compatibility with the underlying platform's preferences storage (so the key was a determinate length and didn't exceed platform limits). | ||
| // As part as Microsofts ongoing efforts to secure the .NET ecosystem, this usage of an insecure hashing mechanism was flagged. | ||
| // An exception has been requested for the usage of this "unsafe" hashing mechanism. | ||
| // More details here (internal link): https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1676270 |
There was a problem hiding this comment.
CI is failing with:
error SA1027: Tabs and spaces should be used correctly
|
Is there an ETA on 1.7.5 milestone with this fix? |
|
Does anyone realise the latest release that this PR went into is not on nuget due to a build failure? Is there anyone able to fix that? |
|
Sorry it took a little while @JaixTim! I have just released it now |
|
@jfversluis are you working on a solution for this? |
|
@suhas100 this is fixed and released as part of Essentials 1.7.5 |
|
@jfversluis - this SO thread says they are using Xamarin.Essentials(1.7.5), but still getting "Denied" when they do |
|
@ToolmakerSteve Note that the SO talks about the read permission when using |
Thanks to @Ghostbird in dotnet/maui#12766
Description of Change
Fix the MediaPicker that is requesting permissions that are not correct for Android 33.
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
None.
Behavioral Changes
Skips the check for
StorageWritebecause that permission is not needed and probably not needed in many versions...PR Checklist
mainat time of PR