Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify a specific plugin version #108

Merged
merged 10 commits into from May 23, 2023
Merged

Verify a specific plugin version #108

merged 10 commits into from May 23, 2023

Conversation

semseysandor
Copy link
Contributor

closes #106

@semseysandor semseysandor requested a review from a team as a code owner May 22, 2023 15:41
@semseysandor
Copy link
Contributor Author

Functional tests are failing, and I don't know the reason. I've tried a few variations and I think the code is working as expected.

Checking the output from "Run Behat" step:

  • wp plugin verify-checksums duplicate-post --format=json --version=3.2.2 returns with exit code 1
  • stdout lists differences between 3.2.1 and 3.2.2
  • stderr has the error message

I believe the same assertions are specified in the scenario (or at least that was my intention), and this is what should happen.

@danielbachhuber do you have any idea?

@semseysandor semseysandor changed the title Verify a specific plugin version WIP: Verify a specific plugin version May 22, 2023
@semseysandor
Copy link
Contributor Author

OK, now tests are passing, it's ready for review!

@semseysandor semseysandor changed the title WIP: Verify a specific plugin version Verify a specific plugin version May 22, 2023
danielbachhuber
danielbachhuber reviewed May 23, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few nits to address, and then it should be ready to ship.

src/Checksum_Plugin_Command.php Outdated Show resolved Hide resolved
src/Checksum_Plugin_Command.php Outdated Show resolved Hide resolved
features/checksum-plugin.feature Show resolved Hide resolved
src/Checksum_Plugin_Command.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
semseysandor and others added 3 commits May 23, 2023 15:46
@semseysandor @danielbachhuber
fix --version description
8df4847 
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
@semseysandor @danielbachhuber
README.md: fix --version description
6fb9ba2 
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
@semseysandor
rename local variable
b7badc3
@danielbachhuber danielbachhuber added this to the 2.2.1 milestone May 23, 2023
@danielbachhuber danielbachhuber self-requested a review May 23, 2023 16:50
danielbachhuber
danielbachhuber approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, @semseysandor !

@danielbachhuber danielbachhuber merged commit 058df1e into wp-cli:main May 23, 2023
30 checks passed
@semseysandor semseysandor deleted the verify-plugin-version branch May 23, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojsmol wojsmol wojsmol left review comments

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
command:plugin-verify-checksums
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

Add --version param to wp plugin verify-checksums
3 participants
@semseysandor @danielbachhuber @wojsmol