New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify a specific plugin version #108
Verify a specific plugin version #108
Conversation
Functional tests are failing, and I don't know the reason. I've tried a few variations and I think the code is working as expected. Checking the output from "Run Behat" step:
I believe the same assertions are specified in the scenario (or at least that was my intention), and this is what should happen. @danielbachhuber do you have any idea? |
Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
OK, now tests are passing, it's ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a few nits to address, and then it should be ready to ship.
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this, @semseysandor !
closes #106