Release 1.104.0 #6204
Merged
Release 1.104.0 #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
commented
Sep 14, 2023
bundle/android/strings.xml
Outdated
| @@ -348,9 +348,6 @@ translators: %s: Select control option value e.g: "Auto, 25%". --> | |||
| <string name="gutenberg_native_slash_inserter_results" tools:ignore="UnusedResources">Slash inserter results</string> | |||
| <string name="gutenberg_native_some_blocks_have_additional_settings_tap_the_settings_icon_on_the" tools:ignore="UnusedResources">Some blocks have additional settings. Tap the settings icon on the bottom right of the block to view more options.</string> | |||
| <string name="gutenberg_native_start_writing" tools:ignore="UnusedResources">Start writing…</string> | |||
| <string name="gutenberg_native_take_a_photo" tools:ignore="UnusedResources">Take a Photo</string> | |||
There was a problem hiding this comment.
This string seems to be only used in the native version, so these changes should be reverted. Not sure why the script in charge of updating the localizations has removed them, I'd need to investigate it further 😞 .
This was referenced Sep 14, 2023
dcalhoun
approved these changes
Sep 14, 2023
# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map # bundle/ios/App.text.js # bundle/ios/App.text.js.map # gutenberg # ios-xcframework/Podfile.lock # package-lock.json # package.json
fluiddot
commented
Sep 19, 2023
package-lock.json
Outdated
| @@ -188,7 +188,7 @@ | |||
| "eslint-plugin-jsdoc": "^46.4.6", | |||
| "eslint-plugin-jsx-a11y": "^6.5.1", | |||
| "eslint-plugin-playwright": "^0.15.3", | |||
| "eslint-plugin-prettier": "^3.3.0", | |||
| "eslint-plugin-prettier": "^5.0.0", | |||
There was a problem hiding this comment.
This change is related to WordPress/gutenberg#54539.
2 tasks
|
The failure in Error: |
# Conflicts: # gutenberg # ios-xcframework/Podfile.lock # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release for Gutenberg Mobile 1.104.0
Related PRs
Extra PRs that Landed After the Release Was Cut
No extra PRs yet. 🎉
Changes
RichText - Update logic for the placeholder text color
feat: Insert from URL leverages a bottom sheet
Test plan
Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.
Release Submission Checklist
RELEASE-NOTES.txtis updated with all the changes that made it to the release. ReplaceUnreleasedsection with the release version and create a newUnreleasedsection.gutenberg/packages/react-native-editor/CHANGELOG.mdis updated with all the changes that made it to the release. Replace## Unreleasedwith the release version and create a new## Unreleased.