Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a manually triggered workflow to release WooCommerce Beta Tester #36387

Merged
merged 6 commits into from Jan 18, 2023

Conversation

samueljseay
Copy link
Contributor

@samueljseay samueljseay commented Jan 12, 2023

All Submissions:

Changes proposed in this Pull Request:

This is a MVP workflow for releasing beta tester. It is fairly manual. Once we have done the version bumping and code edits we are happy with to perform a release of beta tester this workflow can be initiated. My thought is that in future we can automate things like version bumping etc if we need to.

You just choose a version number for the release manually and start the workflow. It will create a release a tagged release on the monorepo that has a name and version unique to WooCommerce Beta Tester. It will never set the release as latest since we should reserve that just for releasing the core plugin.

How to test the changes in this Pull Request:

  1. Fork woocommerce and enable actions
  2. Merge this PR into your fork
  3. Go to Actions tab on your fork -> Find the action and run it, choosing an arbitrary version (e.g. 2.1.0 which is what the plugin version is right now)
  4. It should succeed.
  5. It should create a release under your forks "Releases" section which includes the beta tester plugin zip file as well.
  6. The release should not be marked "latest"

For reference here is a passing action run on my fork: https://github.com/samueljseay/woocommerce/actions/runs/3898558244

and the created release: https://github.com/samueljseay/woocommerce/releases/tag/wc-beta-tester-2.4.0

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@samueljseay samueljseay requested review from a team and roykho and removed request for a team January 12, 2023 01:30
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 12, 2023
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

Test Results Summary

Commit SHA: ed342a7

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 0s
E2E Tests189006019515m 40s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.


- name: Create release
id: create_release
uses: woocommerce/action-gh-release@master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a fork of the action, originally in my own account to test and add changes to support marking a release as "latest" or not. With this fork it now defaults to not marking the release as latest which you can see in my test run listed under test instructions in the PR description.

I have made an upstream PR to the original action so we could hopefully swap to their official version if/when it is merged: softprops/action-gh-release#304

@roykho
Copy link
Member

roykho commented Jan 12, 2023

Hi @samueljseay - is this ready for review?

@samueljseay
Copy link
Contributor Author

@roykho yup!

Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nicely. Good job! Just have a small suggested change.

.github/workflows/release-wc-beta-tester.yml Show resolved Hide resolved
Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samueljseay samueljseay merged commit b1f80c1 into trunk Jan 18, 2023
@samueljseay samueljseay deleted the dev/beta-tester-release-workflow branch January 18, 2023 05:42
@github-actions github-actions bot added this to the 7.4.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants