New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a manually triggered workflow to release WooCommerce Beta Tester #36387
Conversation
Test Results SummaryCommit SHA: ed342a7
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
||
- name: Create release | ||
id: create_release | ||
uses: woocommerce/action-gh-release@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a fork of the action, originally in my own account to test and add changes to support marking a release as "latest" or not. With this fork it now defaults to not marking the release as latest which you can see in my test run listed under test instructions in the PR description.
I have made an upstream PR to the original action so we could hopefully swap to their official version if/when it is merged: softprops/action-gh-release#304
Hi @samueljseay - is this ready for review? |
@roykho yup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested nicely. Good job! Just have a small suggested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
All Submissions:
Changes proposed in this Pull Request:
This is a MVP workflow for releasing beta tester. It is fairly manual. Once we have done the version bumping and code edits we are happy with to perform a release of beta tester this workflow can be initiated. My thought is that in future we can automate things like version bumping etc if we need to.
You just choose a version number for the release manually and start the workflow. It will create a release a tagged release on the monorepo that has a name and version unique to WooCommerce Beta Tester. It will never set the release as latest since we should reserve that just for releasing the core plugin.
How to test the changes in this Pull Request:
2.1.0
which is what the plugin version is right now)For reference here is a passing action run on my fork: https://github.com/samueljseay/woocommerce/actions/runs/3898558244
and the created release: https://github.com/samueljseay/woocommerce/releases/tag/wc-beta-tester-2.4.0
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: