New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parameterized.expand
play nice with underlying mock
patches
#129
Conversation
Greetings, @wolever I've put together a PR that fixes the long-standing issue #66. I'd love to get some feedback on it / hear your thoughts. 😃
Thanks in advance. |
ebb708f
to
d0e76bd
Compare
👍 |
@wolever Please take a look when you can, or perhaps point me to someone else maintaining this project who can help push this forward... It's been a couple of months since I posted and I'd hate for this to get stale again 🙏🏻 |
@wolever Would appreciate some eyes on this, please. It's already been several months 🙏🏻 |
bump, +1 |
Ah! Thank you very much for the time you've put into this, and I'm extremely sorry it took so long to get merged. It's in there now, and will be released as part of 0.9.0. Thank you again! |
Hey folks! Just a heads up: 0.9.0 is out: https://pypi.org/project/parameterized/0.9.0/ |
Fixes issue #66.
This is a workaround for https://bugs.python.org/issue40126 when using
parameterized.expand
along oldmock
versions.Avoid fully stripping out patches from source methods and replace them with a "dummy" no-op patch instead.