Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable list_sessions for session completion #699

Merged
merged 1 commit into from Apr 22, 2023

Conversation

scop
Copy link
Contributor

@scop scop commented Apr 6, 2023

Otherwise we end up erroring out due to no session being selected (which in turn errors out due to global color setting not finalized/available at this phase yet.)

$ eval -- "$(register-python-argcomplete nox)"
$ export _ARC_DEBUG=1
$ nox -s <TAB>
[...]
  File ".../nox/nox/_options.py", line 234, in _session_completer
    filtered_manifest = filter_manifest(manifest, global_config)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../nox/nox/tasks.py", line 185, in filter_manifest
    _produce_listing(manifest, global_config)
  File ".../nox/nox/tasks.py", line 235, in _produce_listing
    reset = parse_colors("reset") if global_config.color else ""
                                     ^^^^^^^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'color'. Did you mean: 'nocolor'?
[...]

Otherwise we end up erroring out due to no session being selected (which
in turn errors out due to global color setting not finalized/available
at this phase yet.)
@crwilcox crwilcox merged commit 45acf03 into wntrblm:main Apr 22, 2023
18 checks passed
@scop scop deleted the fix/session-completion branch April 23, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants