Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci: bump ahash dep and add bitcoind macos arm64 binary hash #1085

Merged
merged 2 commits into from
May 2, 2024

Conversation

edouardparis
Copy link
Member

@edouardparis edouardparis commented Apr 29, 2024

@darosior
Copy link
Contributor

context?

@darosior
Copy link
Contributor

Ok here is the context: tkaitchuck/aHash#195 and tkaitchuck/aHash#207.

@darosior
Copy link
Contributor

However what's the issue with the GUI unit test here? It seems unrelated to this PR.

@darosior
Copy link
Contributor

darosior commented May 2, 2024

Ping @edouardparis

@darosior darosior mentioned this pull request May 2, 2024
@edouardparis
Copy link
Member Author

edouardparis commented May 2, 2024

It seems that rust nightly on macos does not understand anymore this code:

#[cfg(all(target_os = "macos", target_arch = "x86_64"))]
pub const SHA256SUM: &str = "acb50edd20692a9d023de12da573b64ca0fd9b4e9a2b88d1251020a3022b0f27";

#[cfg(all(target_os = "linux", target_arch = "x86_64"))]
pub const SHA256SUM: &str = "a5b7d206384a8100058d3f2e2f02123a8e49e83f523499e70e86e121a4897d5b";

#[cfg(all(target_os = "windows", target_arch = "x86_64"))]
pub const SHA256SUM: &str = "7bd0849e47472aeff99a0ea2c0cefd98f5be829e5a2d3b0168b5a54456cc638a";

And find no SHA256SUM const. I have no way to fix it for now. Maybe something with the target_arch

@edouardparis edouardparis changed the title bump ahash dependency to fix macos build fix ci: bump ahash dep and add bitcoind macos arm64 binary hash May 2, 2024
@darosior
Copy link
Contributor

darosior commented May 2, 2024

ACK 8991210

@darosior darosior merged commit 6b22577 into wizardsardine:master May 2, 2024
21 checks passed
@edouardparis edouardparis deleted the ahash-v0.8.11 branch May 2, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants