Add Optional InfiniteList Support to AgendaList #2270
Conversation
yakirza17
changed the title
yakirza17
changed the title
| (index) => data[index]?.isTitle ? 'title': 'page', | ||
| (type, dim) => { | ||
| dim.width = constants.screenWidth; | ||
| dim.height = type === 'title' ? 60 : 120; |
There was a problem hiding this comment.
should see what the right size to pass, RecyclerListView doesn't support calculating item height
There was a problem hiding this comment.
@ethanshar @Inbal-Tish please give your thoughts
There was a problem hiding this comment.
In the current example, it should be 80 instead of 120, but anyways you'll have to let the user pass the item's height to set it there.
There was a problem hiding this comment.
Created infiniteListProps in the oldAgendaList, with an option to define these values (and load the new component in case it pass - even an empty object)
There was a problem hiding this comment.
@Inbal-Tish It's ok to put values like that? will it work in any view? tablet view? landscape?
There was a problem hiding this comment.
It will stay the same unless you change it when the orientation change. Regarding tablets, it depends on the design of course... Once you give the user the option to set these values it can be dynamic. 'pageWidth' and 'pageHeight' covers that
|
@yakirza17 @chenei Overall looks good. Left a few comments |
|
@yakirza17 Can you add a code snippet for the AgendaList so I can see on what example you're working on? |
|
@Inbal-Tish, add |
Introduces an experimental prop
infiniteListPropstoAgendaList. When defined,AgendaListswitches fromSectionListtoInfiniteList. Be aware, as an experimental feature, it might not support all existing APIs.Additionally, enhances
InfiniteListto accept alayoutProviderfor detailed item size control.