Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change generated source hint names to have a .g.cs suffix #4

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Change generated source hint names to have a .g.cs suffix #4

merged 1 commit into from
Aug 17, 2021

Conversation

GraemeF
Copy link

@GraemeF GraemeF commented Aug 17, 2021

There is a convention that Coverlet depends upon to detect and ignore 3rd-party assemblies.

This issue explains the problem: coverlet-coverage/coverlet#1164

Without the .g.cs suffix it is not possible to generate code coverage in projects that use this package. See dotnet/runtime@f368fcf for an example of a fix for the same issue in the dotnet runtime.

… generation

There is a convention that Coverlet depends upon to detect and ignore 3rd-party assemblies.
This issue explains the problem: coverlet-coverage/coverlet#1164
Without the `.g.cs` suffix it is not possible to generate code coverage in projects that use
this package. See dotnet/runtime@f368fcf
for an example of a fix for the same issue in the dotnet runtime.
@onionhammer onionhammer merged commit 95546c0 into wivuu:master Aug 17, 2021
@onionhammer
Copy link
Contributor

Thanks for the PR!

@GraemeF GraemeF deleted the indicate-generated-code-with-suffix branch August 17, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants