Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add editor icons #2961

Merged
merged 4 commits into from
Mar 18, 2025
Merged

feat: add editor icons #2961

merged 4 commits into from
Mar 18, 2025

Conversation

ematipico
Copy link
Member

Description

This PR adds found new icons: vscode, zed, vim and jetbrains

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: c7d2da6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 13, 2025
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit c7d2da6
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67d96c4e895583000889da34
😎 Deploy Preview https://deploy-preview-2961--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Mar 13, 2025

size-limit report 📦

Path Size
/index.html 6.93 KB (0%)
/_astro/*.js 25.76 KB (0%)
/_astro/*.css 13.8 KB (0%)

@ematipico ematipico closed this Mar 13, 2025
@ematipico ematipico reopened this Mar 13, 2025
@trueberryless
Copy link
Contributor

I don't wanna be rude or anything, but I read your feature request on discord and already created a PR for these icons including some design icons in #2955

But maybe your paths are more optimised, so maybe I should update the PR to not include these icons if you want...?

@delucis
Copy link
Member

delucis commented Mar 18, 2025

Ema unfortunately missed your PR @trueberryless, but it’s ok, happens sometimes 😄

We discussed on Discord and agreed we would apply the jetbrains path from this PR after merging #2955 — they are slightly different and it seems the one in this PR is the “official” icon.

So that means both of you still get to contribute 🎉

delucis added 3 commits March 18, 2025 13:47
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @ematipico! I updated the PR to only apply the JetBrains icon as we discussed 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Mar 18, 2025
@delucis delucis merged commit da57fab into main Mar 18, 2025
15 checks passed
@delucis delucis deleted the feat/editor-icons branch March 18, 2025 12:56
@astrobot-houston astrobot-houston mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants