Fix issue with rewriting

[HiDeoo]

Description

• Closes context.rewrite broken in starlight 0.32.0 #2903

This PR fixes an issue with rewriting, e.g. in a middleware using context.rewrite(), which would cause the following error:

Cannot redefine property: starlightRoute

This is due to the fact that the property is not configurable and rewriting causes any middleware to be re-executed, which would try to redefine the property.

This will trigger a new rendering phase, causing any middleware to be re-executed.

[changeset-bot]

🦋 Changeset detected

Latest commit: eb39529

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@astrojs/starlight	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for astro-starlight ready!

Name	Link
🔨 Latest commit	eb39529
🔍 Latest deploy log	https://app.netlify.com/sites/astro-starlight/deploys/67b6646d7fb7d00008256266
😎 Deploy Preview	https://deploy-preview-2904--astro-starlight.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ringods]

@HiDeoo @delucis I'm on 0.32.1 but still see this error:

 generating static routes
10:33:16 ▶ @astrojs/starlight/routes/static/404.astro
10:33:16   └─ /404.htmlEntry docs → 404 was not found.
Cannot read properties of undefined (reading 'find')

Didn't have this on 0.30.3. Is this still related or should I file a new issue?

[delucis]

Hey @ringods — that sounds like a different error. A new issue with a minimal reproduction would be great, thank you!