-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @types/js-yaml
to normal dependencies
#2650
Conversation
🦋 Changeset detectedLatest commit: 33ec151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @raviqqe!
* main: Move `@types/js-yaml` to normal dependencies (withastro#2650) [ci] format i18n(ru): update some translations (withastro#2643)
Description
This PR moves the
@types/js-yaml
package into a normal dependency in the@astrojs/starlight
package.Because we export TypeScript files directly in the
exports
field in apackage.json
file of the@astrojs/starlight
package, we need to include all dependencies'@types/*
packages in normal dependencies. Otherwise, we get following errors on type check of, for example,astro.config.ts
even withskipLibCheck: true
intsconfig.json
: