-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudflare): target es2022 instead of es2020 to fix esbuild incompatibility issues #8682
fix(cloudflare): target es2022 instead of es2020 to fix esbuild incompatibility issues #8682
Conversation
…patibility issues
🦋 Changeset detectedLatest commit: a94243c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dario-piotrowicz Fantastic work! 🚀
I've verified that CF Workers & Pages support es2022. Given that all existing tests have passed, there's no need for additional tests. Documentation updates aren't necessary either.
Thanks a lot @alexanderniebuhr ❤️, and thanks for cleaning up the PR and adding the one spot I missed 🙈 |
@dario-piotrowicz Checking in on this. I'd like to confirm if the documentation team has reviewed the changeset. Once that's done, this will be ready for merge, and I'll expedite the process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs approves the changeset! 🥳
Changes
The Cloudflare adapter currently uses esbuild targeting es2020, this works fine but this can be problematic when used with some astro integrations, like
@astrojs/mdx
, the issue being that mdx seems to use top-level awaits not supported by es2020So if I have an astro config such as this:
and try to build my application I get the following:
Testing
I'm not sure if such a small change requires tests, please let me know if I should look into adding those
Docs
There isn't really any documentation to add as this is a simple change that should not be visible to users.