Fix the path to type definitions in ImportMeta #8360
Closed
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vite no longer expose `vite/types/importGlob` and `vite/types/importGlob`
🦋 Changeset detectedLatest commit: 07be5f0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
reviewed
Sep 4, 2023
There was a problem hiding this comment.
I think this change is fine, presumably it doesn't work because vite/types/* isn't exported from Vite's package.json ``"exports'`? I think it could be fixed upstream.
There's also line 12 hitting this problem, but it's not exported from "vite" index.
There was a problem hiding this comment.
I open the PR for Vite. vitejs/vite#14296
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed the path for type definitions for
import.meta.globandimport.meta.globEager. This is because Vite no longer exposesvite/types/importGlobandvite/types/importGlob, and it needs to be imported fromviteinstead.Testing
Verified the type definitions for
import.meta.globandimport.meta.globEagerin files that importimport-meta.d.ts.Docs
No additional documentation is required to detail the implementation.