Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EndpointOutput type with encoding 'binary' #8003

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Aug 8, 2023

Changes

Fixes EndpointOutput type.

// Before
const output: EndpointOutput = {
  body: someBuffer, // Error! "Should be a string"
  encoding: 'binary',
}

// After
const output: EndpointOutput = {
  body: someBuffer, // Ok!
  encoding: 'binary',
}

Testing

Just types updates

Docs

Docs already describe the desired behavior

JuanM04 added 2 commits August 8, 2023 19:10

Verified

This commit was signed with the committer’s verified signature.
JuanM04 Juan Martín Seery

Verified

This commit was signed with the committer’s verified signature.
JuanM04 Juan Martín Seery
@JuanM04 JuanM04 requested a review from a team as a code owner August 8, 2023 22:17
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 9773861

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 8, 2023
@JuanM04 JuanM04 merged commit 16161af into main Aug 8, 2023
@JuanM04 JuanM04 deleted the fix-encoding-type branch August 8, 2023 23:19
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants