Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair server islands to work with client router #13481

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Repair server islands to work with client router #13481

merged 2 commits into from
Mar 21, 2025

Conversation

martrapp
Copy link
Member

Changes

Fixes #13461 by adding data-astro-rerun

Docs

n.a. / bug fix

Verified

This commit was signed with the committer’s verified signature.
wagoodman Alex Goodman

Verified

This commit was signed with the committer’s verified signature.
wagoodman Alex Goodman
Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: e4ba218

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 21, 2025
Copy link

codspeed-hq bot commented Mar 21, 2025

CodSpeed Performance Report

Merging #13481 will not alter performance

Comparing mt/rerun (e4ba218) with main (53abc9d)

Summary

✅ 6 untouched benchmarks

@martrapp martrapp requested a review from matthewp March 21, 2025 10:48
@martrapp martrapp changed the title Mt/rerun Repair server islands to work with client router Mar 21, 2025
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@martrapp martrapp merged commit e9e9245 into main Mar 21, 2025
15 of 16 checks passed
@martrapp martrapp deleted the mt/rerun branch March 21, 2025 12:46
@astrobot-houston astrobot-houston mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using ClientRouter, server island won't run when navigating to a page with island via router
2 participants