Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): handle boolean server.allowedHosts #13437

Merged

Conversation

Vardhaman619
Copy link
Contributor

Changes

Testing

  • Manually tested by setting allowedHosts: true in astro.config.mjs.
  • Verified that astro info and astro dev no longer throw configuration errors.

Docs

No documentation updates needed as this aligns with existing Vite behavior.

Copy link

changeset-bot bot commented Mar 16, 2025

🦋 Changeset detected

Latest commit: 85c228a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 16, 2025
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #13437 will not alter performance

Comparing Vardhaman619:fix/config-server-allowed-hosts (85c228a) with main (1eab0b2)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vardhaman619!

@ematipico ematipico merged commit 013fa87 into withastro:main Mar 18, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New 'server.allowedHosts' config does not allow the value 'true'
2 participants