Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad values in x-forwarded-host #13428

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Handle bad values in x-forwarded-host #13428

merged 3 commits into from
Mar 18, 2025

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test added

Docs

N/A, bug fix

If a bad value is provide by this header, we simply ignore it and
fallback to the host provided by the host header (if there is one).
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: b9fbf1e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 14, 2025
Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #13428 will not alter performance

Comparing url-bad-header (b9fbf1e) with main (1a93637)

Summary

✅ 6 untouched benchmarks

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@matthewp matthewp merged commit 9cac9f3 into main Mar 18, 2025
15 checks passed
@matthewp matthewp deleted the url-bad-header branch March 18, 2025 13:02
@astrobot-houston astrobot-houston mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro SSR node adapter returns (500 Internal Server Error) when bad x-forwarded-host is passed
3 participants