Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new method insertPageRoute to container #13358

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

ematipico
Copy link
Member

Changes

Closes #13264

This PR adds support for Astro.rewrite for the container API. A new method called insertPageRoute has been exposed that will help users to test routes that trigger a possible rewrite.

Testing

I added a new test

Docs

Will create a PR

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: e27ab9e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ematipico ematipico force-pushed the feat/container-rewrite branch from 5d44456 to 4abed4a Compare March 4, 2025 13:11
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #13358 will not alter performance

Comparing feat/container-rewrite (e27ab9e) with main (7783dbf)

Summary

✅ 6 untouched benchmarks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only used for rewrites? The naming might be confusing.

@ematipico
Copy link
Member Author

Is this only used for rewrites? The naming might be confusing.

I want to keep the name generic. While there's a use case for rewrites, it could be possible to support redirects too.

Co-authored-by: Matt Kane <m@mk.gg>
@ematipico ematipico merged commit 8c21663 into main Mar 18, 2025
5 checks passed
@ematipico ematipico deleted the feat/container-rewrite branch March 18, 2025 09:32
@astrobot-houston astrobot-houston mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container API crashes when rendering a page that contains Astro.rewrite
3 participants