fix: allow special characters in Action names #12124
Merged
+72
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88d1143 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Oct 4, 2024
Princesseuh
approved these changes
Oct 4, 2024
|
Think I agree with @Princesseuh here. Decode URI component is simple enough for us to maintain, so I'd like to keep the feature. Totally open to disallowing special characters if we see further bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Action paths are mapped to action names, with a dot representing nested properties. However the action names are not escaped, so special characters and dots in the name cause the action to be not found. This PR encodes special chacaters and dots in names before using them in the URL.
Fixes #11905
Testing
Adds test cases
Docs