Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Actions accept type completions #11436

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Fix: Actions accept type completions #11436

merged 4 commits into from
Jul 9, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

Fixes the issue originally reported by #11292

Default the accept property to undefined instead of json. This shows the correct string completions while preserving behavior when accept is omitted.

Testing

Manual type testing

Docs

N/A

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 2efa5e2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 9, 2024
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this PR include some types tests using https://github.com/mmkal/expect-type?

bholmesdev and others added 4 commits July 9, 2024 16:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@bholmesdev bholmesdev merged commit 7dca68f into main Jul 9, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/action-type branch July 9, 2024 20:35
@astrobot-houston astrobot-houston mentioned this pull request Jul 9, 2024
ematipico pushed a commit that referenced this pull request Jul 18, 2024
* fix: `accept` type completions

* chore: changeset

* Edit: fix -> fixes astro:actions

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>

* feat(test): accept types

---------

Co-authored-by: bholmesdev <bholmesdev@gmail.com>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants