Skip to content

Commit

Permalink
Handle noscript tags in head during ViewTransitions (#8091)
Browse files Browse the repository at this point in the history
martrapp authored Aug 15, 2023

Verified

This commit was signed with the committer’s verified signature.
hickford M Hickford
1 parent 76a2ba2 commit 56e7c51
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/shaggy-cameras-hide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Handle `<noscript>` tags in `<head>` during ViewTransitions
4 changes: 4 additions & 0 deletions packages/astro/components/ViewTransitions.astro
Original file line number Diff line number Diff line change
@@ -125,6 +125,10 @@ const { fallback = 'animate' } = Astro.props as Props;
};

const swap = () => {
// noscript tags inside head element are not honored on swap (#7969).
// Remove them before swapping.
doc.querySelectorAll('head noscript').forEach((el) => el.remove());

// Swap head
for (const el of Array.from(document.head.children)) {
const newEl = persistedHeadElement(el);

0 comments on commit 56e7c51

Please sign in to comment.