Change interface to class in exported types #2157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class constructor should be exported as class instead of interface.
Why does this matter? Interface is removed in runtime after compilation. But actually, types like
Logger
is accessible in pure js. For my use case, I'll need a runtime type as a dependency injection token, as well as a well-typed interface.Another reason is class is inheritable, but if one wants to make a class extending interface, he/she should implement all the methods declared in interface.
Ref: https://stackoverflow.com/questions/14345485/whats-the-difference-between-declare-class-and-interface-in-typescript