Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add php #3725

Merged
merged 3 commits into from
May 15, 2024
Merged

feat: add php #3725

merged 3 commits into from
May 15, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented May 14, 2024

🚀 This description was created by Ellipsis for commit 85f0387

Summary:

This pull request integrates PHP support into the platform, enhancing its capabilities to support a wider range of programming languages.

Key points:

  • Added PHP support across multiple components.
  • Updated Docker configurations to include PHP and Composer.
  • Modified backend SQL queries to recognize PHP.
  • Enhanced frontend components for syntax highlighting and editor support for PHP.
  • Integrated PHP in script execution workflows.

Generated with ❤️ by ellipsis.dev

Copy link

cloudflare-pages bot commented May 14, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85f0387
Status: ✅  Deploy successful!
Preview URL: https://20c1b53f.windmill.pages.dev
Branch Preview URL: https://hugo-win-38-add-php.windmill.pages.dev

View logs

@HugoCasa HugoCasa marked this pull request as ready for review May 14, 2024 13:54
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 85f0387 in 2 minutes and 8 seconds

More details
  • Looked at 2000 lines of code in 48 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/lib/script_helpers.ts:193
  • Draft comment:
    Consider providing more explicit instructions or an active example for the Composer package requirements in the PHP initialization code to enhance clarity for users.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_cNsopijauARORMUE


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

2 days left in your free trial, upgrade for $20/seat/month or contact us.

Copy link
Contributor

🔍 Vulnerabilities of ghcr.io/windmill-labs/windmill-ee:main

📦 Image Reference ghcr.io/windmill-labs/windmill-ee:main
digestsha256:4f667fbf04150b6aa68fa98b683ad9c34ae3477d6315732402b294f2dae4f9ea
vulnerabilitiescritical: 0 high: 14 medium: 0 low: 0
size872 MB
packages1377
📦 Base Image python:3.11-slim
also known as
  • 3.11-slim-bookworm
  • 3.11.8-slim
  • 3.11.8-slim-bookworm
digestsha256:4bcdb5d5bc81caf410bc880ca7d47d6ce3f05dc50f81166eb42827fcdc98cfca
vulnerabilitiescritical: 0 high: 3 medium: 1 low: 30 unspecified: 5
critical: 0 high: 4 medium: 0 low: 0 pillow 9.4.0 (pypi)

pkg:pypi/pillow@9.4.0

# Dockerfile (168:168)
COPY --from=builder /frontend/build /static_frontend

high 8.8: CVE--2023--4863 Out-of-bounds Write

Affected range<10.0.1
Fixed version10.0.1
CVSS Score8.8
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score68.00%
EPSS Percentile98th percentile
Description

Heap buffer overflow in libwebp allow a remote attacker to perform an out of bounds memory write via a crafted HTML page.

high 8.1: CVE--2023--50447 Improper Control of Generation of Code ('Code Injection')

Affected range<10.2.0
Fixed version10.2.0
CVSS Score8.1
CVSS VectorCVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H
EPSS Score0.07%
EPSS Percentile31st percentile
Description

Pillow through 10.1.0 allows PIL.ImageMath.eval Arbitrary Code Execution via the environment parameter, a different vulnerability than CVE-2022-22817 (which was about the expression parameter).

high 7.5: CVE--2023--44271 Uncontrolled Resource Consumption

Affected range<10.0.0
Fixed version10.0.0
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score0.05%
EPSS Percentile22nd percentile
Description

An issue was discovered in Pillow before 10.0.0. It is a Denial of Service that uncontrollably allocates memory to process a given task, potentially causing a service to crash by having it run out of memory. This occurs for truetype in ImageFont when textlength in an ImageDraw instance operates on a long text argument.

high : GHSA--56pw--mpj4--fxww

Affected range<10.0.1
Fixed version10.0.1
Description

Pillow versions before v10.0.1 bundled libwebp binaries in wheels that are vulnerable to CVE-2023-5129 (previously CVE-2023-4863). Pillow v10.0.1 upgrades the bundled libwebp binary to v1.3.2.

critical: 0 high: 3 medium: 0 low: 0 cryptography 38.0.4 (pypi)

pkg:pypi/cryptography@38.0.4

# Dockerfile (106:108)
RUN apt-get update \
    && apt-get install -y ca-certificates wget curl git jq unzip build-essential unixodbc xmlsec1  software-properties-common \
    && rm -rf /var/lib/apt/lists/*

high 7.5: CVE--2024--26130 NULL Pointer Dereference

Affected range>=38.0.0
<42.0.4
Fixed version42.0.4
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score0.04%
EPSS Percentile15th percentile
Description

If pkcs12.serialize_key_and_certificates is called with both:

  1. A certificate whose public key did not match the provided private key
  2. An encryption_algorithm with hmac_hash set (via PrivateFormat.PKCS12.encryption_builder().hmac_hash(...)

Then a NULL pointer dereference would occur, crashing the Python process.

This has been resolved, and now a ValueError is properly raised.

Patched in pyca/cryptography#10423

high 7.5: CVE--2023--50782 Observable Discrepancy

Affected range<42.0.0
Fixed version42.0.0
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
EPSS Score0.10%
EPSS Percentile41st percentile
Description

A flaw was found in the python-cryptography package. This issue may allow a remote attacker to decrypt captured messages in TLS servers that use RSA key exchanges, which may lead to exposure of confidential or sensitive data.

high 7.4: CVE--2023--0286 Access of Resource Using Incompatible Type ('Type Confusion')

Affected range>=0.8.1
<39.0.1
Fixed version39.0.1
CVSS Score7.4
CVSS VectorCVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:H
EPSS Score0.21%
EPSS Percentile59th percentile
Description

pyca/cryptography's wheels include a statically linked copy of OpenSSL. The versions of OpenSSL included in cryptography 0.8.1-39.0.0 are vulnerable to a security issue. More details about the vulnerabilities themselves can be found in https://www.openssl.org/news/secadv/20221213.txt and https://www.openssl.org/news/secadv/20230207.txt.

If you are building cryptography source ("sdist") then you are responsible for upgrading your copy of OpenSSL. Only users installing from wheels built by the cryptography project (i.e., those distributed on PyPI) need to update their cryptography versions.

critical: 0 high: 2 medium: 0 low: 0 glibc 2.36-9+deb12u4 (deb)

pkg:deb/debian/glibc@2.36-9%2Bdeb12u4?os_distro=bookworm&os_name=debian&os_version=12

# Dockerfile (93:93)
FROM ${PYTHON_IMAGE}

high : CVE--2024--33601

Affected range<2.36-9+deb12u7
Fixed version2.36-9+deb12u7
EPSS Score0.04%
EPSS Percentile8th percentile
Description

nscd: netgroup cache may terminate daemon on memory allocation failure The Name Service Cache Daemon's (nscd) netgroup cache uses xmalloc or xrealloc and these functions may terminate the process due to a memory allocation failure resulting in a denial of service to the clients. The flaw was introduced in glibc 2.15 when the cache was added to nscd. This vulnerability is only present in the nscd binary.

high : CVE--2024--2961

Affected range<2.36-9+deb12u6
Fixed version2.36-9+deb12u6
EPSS Score0.04%
EPSS Percentile12th percentile
Description

The iconv() function in the GNU C Library versions 2.39 and older may overflow the output buffer passed to it by up to 4 bytes when converting strings to the ISO-2022-CN-EXT character set, which may be used to crash an application or overwrite a neighbouring variable.

critical: 0 high: 1 medium: 0 low: 0 pillow 9.4.0-1.1 (deb)

pkg:deb/debian/pillow@9.4.0-1.1?os_distro=bookworm&os_name=debian&os_version=12

# Dockerfile (168:168)
COPY --from=builder /frontend/build /static_frontend

high : CVE--2023--50447

Affected range>=9.4.0-1.1
Fixed versionNot Fixed
EPSS Score0.07%
EPSS Percentile31st percentile
Description

Pillow through 10.1.0 allows PIL.ImageMath.eval Arbitrary Code Execution via the environment parameter, a different vulnerability than CVE-2022-22817 (which was about the expression parameter).

critical: 0 high: 1 medium: 0 low: 0 libyaml 0.2.5-1 (deb)

pkg:deb/debian/libyaml@0.2.5-1?os_distro=bookworm&os_name=debian&os_version=12

# Dockerfile (106:108)
RUN apt-get update \
    && apt-get install -y ca-certificates wget curl git jq unzip build-essential unixodbc xmlsec1  software-properties-common \
    && rm -rf /var/lib/apt/lists/*

high : CVE--2024--3205

Affected range>=0.2.5-1
Fixed versionNot Fixed
EPSS Score0.04%
EPSS Percentile15th percentile
Description

A vulnerability was found in yaml libyaml up to 0.2.5 and classified as critical. Affected by this issue is the function yaml_emitter_emit_flow_sequence_item of the file /src/libyaml/src/emitter.c. The manipulation leads to heap-based buffer overflow. The attack may be launched remotely. The exploit has been disclosed to the public and may be used. The identifier of this vulnerability is VDB-259052. NOTE: The vendor was contacted early about this disclosure but did not respond in any way.

critical: 0 high: 1 medium: 0 low: 0 System.Data.SqlClient 4.8.5 (nuget)

pkg:nuget/System.Data.SqlClient@4.8.5

# Dockerfile (111:122)
RUN if [ "$WITH_POWERSHELL" = "true" ]; then \
    if [ "$TARGETPLATFORM" = "linux/amd64" ]; then apt-get update -y && apt install libicu-dev -y && wget -O 'pwsh.deb' "https://github.com/PowerShell/PowerShell/releases/download/v${POWERSHELL_VERSION}/powershell_${POWERSHELL_DEB_VERSION}.deb_amd64.deb" && \
    dpkg --install 'pwsh.deb' && \
    rm 'pwsh.deb'; \
    elif [ "$TARGETPLATFORM" = "linux/arm64" ]; then apt-get update -y && apt install libicu-dev -y && wget -O powershell.tar.gz "https://github.com/PowerShell/PowerShell/releases/download/v${POWERSHELL_VERSION}/powershell-${POWERSHELL_VERSION}-linux-arm64.tar.gz" && \
    mkdir -p /opt/microsoft/powershell/7 && \
    tar zxf powershell.tar.gz -C /opt/microsoft/powershell/7 && \
    chmod +x /opt/microsoft/powershell/7/pwsh && \
    ln -s /opt/microsoft/powershell/7/pwsh /usr/bin/pwsh && \
    rm powershell.tar.gz; \
    else echo 'Could not install pwshell, not on amd64 or arm64'; fi;  \
    else echo 'Building the image without powershell'; fi

high 8.7: CVE--2024--0056 Cleartext Transmission of Sensitive Information

Affected range<4.8.6
Fixed version4.8.6
CVSS Score8.7
CVSS VectorCVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:N
EPSS Score0.16%
EPSS Percentile52nd percentile
Description

Microsoft.Data.SqlClient and System.Data.SqlClient SQL Data Provider Security Feature Bypass Vulnerability

critical: 0 high: 1 medium: 0 low: 0 pip 24.0 (pypi)

pkg:pypi/pip@24.0

# Dockerfile (93:93)
FROM ${PYTHON_IMAGE}

high 7.8: CVE--2018--20225 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range>=0
Fixed versionNot Fixed
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score0.11%
EPSS Percentile44th percentile
Description

An issue was discovered in pip (all versions) because it installs the version with the highest version number, even if the user had intended to obtain a private package from a private index. This only affects use of the --extra-index-url option, and exploitation requires that the package does not already exist in the public index (and thus the attacker can put the package there with an arbitrary version number).

critical: 0 high: 1 medium: 0 low: 0 nodejs 20.12.2-1nodesource1 (deb)

pkg:deb/debian/nodejs@20.12.2-1nodesource1?os_distro=bookworm&os_name=debian&os_version=12

# Dockerfile (168:168)
COPY --from=builder /frontend/build /static_frontend

high : CVE--2024--27983

Affected range>=18.13.0+dfsg1-1
Fixed versionNot Fixed
EPSS Score0.04%
EPSS Percentile15th percentile
Description

An attacker can make the Node.js HTTP/2 server completely unavailable by sending a small amount of HTTP/2 frames packets with a few HTTP/2 frames inside. It is possible to leave some data in nghttp2 memory after reset when headers with HTTP/2 CONTINUATION frame are sent to the server and then a TCP connection is abruptly closed by the client triggering the Http2Session destructor while header frames are still being processed (and stored in memory) causing a race condition.

@rubenfiszel rubenfiszel merged commit 6e805d8 into main May 15, 2024
15 of 17 checks passed
@rubenfiszel rubenfiszel deleted the hugo/win-38-add-php branch May 15, 2024 06:12
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants