workspaces working in dev #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgorrie
added
the
improvement ✨
added 6 commits
December 7, 2018 17:19
…org into workspaces
|
I've done a test, and this now means the react us the same version, so we're back in action with hooks. |
5 tasks
gestchild
approved these changes
Dec 11, 2018
davidpmccormick
approved these changes
Dec 11, 2018
Let's pair on that so we can see if it feels right. Is there a reason, or just a feeling? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to get hooks working across all of our application, I hit the stumbling block of React not being the same instance of react on the client when rendering from
commonvscatalogue|content.FYI: facebook/react#13991
This made me think that we could probably get around this using workspaces.
Workspaces also make dependency management a bit nicer, it also remove the
linkwecostep, which is a bit odd.It does however mean you need to run
yarnfrom the root now, which slightly coupley, but the apps are coupled tocommon.This did make me wonder if we had a
./appsfolder withcontent,common, andcontentin. Thoughts? Could be adding layers for nothing, or nicely compartmentalised?There was some Sass resolving issues, but as we're moving away from Sass, the hack felt fine.