- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 49
Consolidate list page endpoints + better QA sorting #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+174
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Feb 20, 2025
•
edited
Loading
edited
- consolidate list_pages() and list_replay_query_pages() into list_pages()
- to keep backwards compatibility, add /pagesSearch that does not include page totals, keep /pages with page total (slower)
- qa frontend: add default 'Crawl Order' sort order, to better show pages in QA view
- bgjob: account for parallelism in bgjobs, add logging if succeeded mismatches parallelism
tw4l
reviewed
Feb 20, 2025
tw4l
reviewed
Feb 20, 2025
tw4l
reviewed
Feb 20, 2025
tw4l
reviewed
Feb 20, 2025
ffb8301
to
39cb347
Compare
All tests now pass - also updated pageUrlCounts to also use list_pages() to avoid duplication. |
tw4l
reviewed
Feb 21, 2025
tw4l
approved these changes
Feb 21, 2025
…s(): - only include total computation if include_total=True is set - don't use facets, but use $limit and $skip - update qa to set includeTotal
…bined with text search
support larger_resources for ops-driven background jobs
5a39135
to
f2661a6
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
f2661a6
to
8d65f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.