Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More accurate archived item details #2364

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Feb 5, 2025

Resolves #2334

Changes

  • Moves page count out from under "Size" label in archived item detail
  • Renames "Pages Crawled" to "Pages" in archived item leading heading and detail overview
  • Renames "Crawl ID" to "Archived Item ID"

Screenshots

Page Image/video
Archived Items Screenshot 2025-02-05 at 12 27 11 PM
Archived Item - Overview Screenshot 2025-02-05 at 12 30 43 PM

@SuaYoo SuaYoo changed the title fix: Separate out archived item page count from size fix: More accurate archived item details Feb 5, 2025
@SuaYoo SuaYoo marked this pull request as ready for review February 5, 2025 20:32
@SuaYoo SuaYoo marked this pull request as draft February 10, 2025 19:24
@SuaYoo SuaYoo marked this pull request as ready for review February 10, 2025 21:43
@SuaYoo SuaYoo requested a review from tw4l February 10, 2025 21:43
This reverts commit 068447f.
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you reverted my commit to fix in #2378? Either way, looks good!

@SuaYoo SuaYoo merged commit 0e04fd9 into main Feb 12, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-separate-archived-item-page-count-size branch February 12, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate archived item page count out from size
4 participants