Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge org public gallery settings #2356

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Merge org public gallery settings #2356

merged 5 commits into from
Feb 10, 2025
+410 −401

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Feb 3, 2025 •
edited
Loading

Resolves #2339

Changes

  • Merges public gallery settings into general org settings
  • Adds help text to "Org URL" to highlight impact of changing slug

Manual testing

  1. Log in as org admin to org without public gallery enabled
  2. Go to Settings
  3. Type in different Org URL. Verify blue help text updates as expected
  4. Enable public collections gallery and save. Verify Org URL example now contains public gallery
  5. Update gallery description and website. Verify gallery is updated as expected

Screenshots

Page Image/video
Org Settings (gallery disabled) Screenshot 2025-02-03 at 1 23 30 PM
Org Settings (gallery enabled) Screenshot 2025-02-03 at 1 23 42 PM

SuaYoo added 4 commits February 3, 2025 12:09
@SuaYoo
add example
eb48765
@SuaYoo
update styles

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a488521
@SuaYoo
move general to component

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1b0fe5c
@SuaYoo
update submit

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
92a9a49
@SuaYoo SuaYoo marked this pull request as ready for review February 3, 2025 21:30
@SuaYoo
add subheading

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
443a495
@SuaYoo
Copy link
Member Author

SuaYoo commented Feb 4, 2025

@Shrinks99 Updated to:

Screenshot 2025-02-04 at 3 21 40 PM

@SuaYoo SuaYoo requested a review from Shrinks99 February 4, 2025 23:22
Shrinks99
Shrinks99 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@SuaYoo SuaYoo merged commit a04a228 into main Feb 10, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-public-gallery-org-settings branch February 10, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer

@Shrinks99 Shrinks99

@emma-sg emma-sg

@tw4l tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move public gallery org settings
4 participants
@SuaYoo @ikreymer @Shrinks99 @emma-sg