Add support for custom link selectors to backend #2346
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
reviewed
Jan 29, 2025
SuaYoo
reviewed
Jan 29, 2025
tw4l
force-pushed
the
issue-2152-custom-link-selectors
branch
from
996b36b to
68fb83e
Compare
ikreymer
reviewed
Jan 30, 2025
Co-authored-by: Ilya Kreymer <ikreymer@users.noreply.github.com>
tw4l
commented
Feb 3, 2025
6 tasks
|
@ikreymer needs your review but should be good to go now |
SuaYoo
approved these changes
Feb 5, 2025
| @@ -36,6 +36,7 @@ export type SeedConfig = Expand< | |||
| failOnFailedSeed?: boolean; | |||
| depth?: number | null; | |||
| userAgent?: string | null; | |||
| selectLinks: string[]; | |||
ikreymer
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2152
This PR adds backend support for custom link selectors via
selectLinkson the crawl workflow config. Tests have been updated as well.It also adds
selectLinksto the frontend in a minimal and for now hardcoded way that we can use as a basis for proper frontend support moving forward.